[Sync] Document refactoring (title)

utils/Sync/sync/models/Document.py

@@ -66,6 +66,10 @@ class Document(Model):
         sizes = kwargs['sizes']
         await self.create_preview(sizes)
 
+        pdf_title = get_pdf_title(self.provider, self.file)
+        if pdf_title:
+            self.title = pdf_title
+
     async def save(self):
         document = self.bake()
 
@@ -99,10 +103,7 @@ class Document(Model):
                 'size': self.provider.size(file)
             },
             'preview': self.preview,
-            'title': last_good([
-                self.title,
-                get_pdf_title(self.provider, self.file)
-            ]),
+            'title': self.title,
         }
 
     def __filename(self):

utils/Sync/utils/fn.py

@@ -43,11 +43,3 @@ def until(condition_fn, iter_fn, items, default_value=None):
         if condition_fn(result):
             return result
     return default_value
-
-
-def last_good(ls):
-    better = None
-    for i in ls:
-        if (i is not None) and i != '':
-            better = i
-    return better